Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Usage of ?? instead of boolean type #1688

Closed
bagipro opened this issue Sep 28, 2022 · 1 comment
Closed

[core] Usage of ?? instead of boolean type #1688

bagipro opened this issue Sep 28, 2022 · 1 comment
Labels
bug Core Issues in jadx-core module

Comments

@bagipro
Copy link
Collaborator

bagipro commented Sep 28, 2022

Hey!

APK: https://drive.google.com/file/d/1XBpFGkIORvQkPu8sYaWFpSZ1ZI87QpxR/view?usp=sharing

File com/samsung/context/sdk/samsunganalytics/internal/sender/DMA/DMALogSender.java:

    public void sendCommon() {
        ?? isEnableUseInAppLogging = this.configuration.isEnableUseInAppLogging(); // <<< it should be `boolean`
@bagipro bagipro added bug Core Issues in jadx-core module labels Sep 28, 2022
skylot added a commit that referenced this issue Oct 2, 2022
@skylot
fix: correct fix for all use places of incompatible primitives (#1688)
711419a
@skylot
Copy link
Owner

skylot commented Oct 2, 2022

Fixed. Thank you for this case 👍

@skylot skylot closed this as completed Oct 2, 2022
@anantshri anantshri mentioned this issue Oct 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Core Issues in jadx-core module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skylot @bagipro