[gui] missing search result

[Ylarod]

Results in res/values/styles.xml is missing from search dialog.

By the way, one error occured immediatly after I toggled on the Active tab only switch.

Jadx version : dev
Java version : 11.0.18
Java VM      : Homebrew OpenJDK 64-Bit Server VM
Platform     : Mac OS X (13.2.1 aarch64)
Max heap size: 11472 MB
Program args : -Xms128M -XX:MaxRAMPercentage=70.0 -XX:+UseG1GC -Dawt.useSystemAAFontSettings=lcd -Dswing.aatext=true -Djava.util.Arrays.useLegacyMergeSort=true

io.reactivex.exceptions.OnErrorNotImplementedException: The exception was not handled due to missing onError handler in the subscribe() method call. Further reading: https://github.com/ReactiveX/RxJava/wiki/Error-Handling | java.lang.NullPointerException
	at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:704)
	at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:701)
	at io.reactivex.internal.subscribers.LambdaSubscriber.onError(LambdaSubscriber.java:79)
	at io.reactivex.internal.subscribers.LambdaSubscriber.onNext(LambdaSubscriber.java:69)
	at io.reactivex.internal.operators.flowable.FlowableObserveOn$ObserveOnSubscriber.runAsync(FlowableObserveOn.java:407)
	at io.reactivex.internal.operators.flowable.FlowableObserveOn$BaseObserveOnSubscriber.run(FlowableObserveOn.java:176)
	at io.reactivex.internal.schedulers.ExecutorScheduler$ExecutorWorker$BooleanRunnable.run(ExecutorScheduler.java:288)
	at io.reactivex.internal.schedulers.ExecutorScheduler$ExecutorWorker.run(ExecutorScheduler.java:253)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.NullPointerException
	at jadx.gui.ui.dialog.SearchDialog.buildSearch(SearchDialog.java:457)
	at jadx.gui.ui.dialog.SearchDialog.prepareSearch(SearchDialog.java:441)
	at jadx.gui.ui.dialog.SearchDialog.search(SearchDialog.java:404)
	at io.reactivex.internal.subscribers.LambdaSubscriber.onNext(LambdaSubscriber.java:65)
	... 7 more

Apk: com.google.android.apps.maps.apk

Jadx version: 77892f4

Installed by brew install jadx --HEAD

[skylot]

Results in res/values/styles.xml is missing from search dialog.

@Ylarod well, turns out that this file was skipped due to size limit which can be changed in preferences. Such behavior can be confusing, so I add additional info for skipped files count with suggestion to check logs for details. If you don't need this limit, just set it to 0 to completely disable resources size checks on search.

error occured immediatly after I toggled on the Active tab only switch.

Also fixed. Thanks for report 👍

[jpstotz]

@skylot Isn't the part of the error message that talks about the "missing onError in the subscribe() method call" something that should be improved?

Edit: I just noticed that already have an issue covering this problem: #1676

[skylot]

@jpstotz this is a wrapper for an exception thrown inside RxJava chain. This can be handled for every call by adding onError(...) or can be registered a global handler, but as a result it will be the same as unhandled exception catch you implemented. Also, most of such exceptions are unexpected, so I don't think it is possible to correctly process them.