Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Project save speed regression #2302

Closed
pubiqq opened this issue Oct 11, 2024 · 1 comment
Closed

[core] Project save speed regression #2302

pubiqq opened this issue Oct 11, 2024 · 1 comment
Assignees
@skylot
Labels
bug Core Issues in jadx-core module regression

Comments

@pubiqq
Copy link
Contributor

pubiqq commented Oct 11, 2024 •
edited
Loading

Issue details

The speed of saving projects (File -> Save all...) has significantly decreased after 964bd62 (in my case, from ~15 sec to ~1m 20 sec).
@pubiqq pubiqq added bug Core Issues in jadx-core module labels Oct 11, 2024
@skylot skylot self-assigned this Oct 11, 2024
skylot added a commit that referenced this issue Oct 12, 2024
@skylot
fix: replace patched zip early in input files (#2302)
b872ffd
@skylot
Copy link
Owner

skylot commented Oct 12, 2024

Fixed.
A solution is to scan and replace patched zip files very early in input files.
Main issue actually is that some jadx code and also plugins API forces to open same zip file several times, to resolve this we need to implement new API to allow traverse files in already opened zip.

Related to PR #2298.

@skylot skylot closed this as completed Oct 12, 2024
@skylot skylot mentioned this issue Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skylot skylot

Labels
bug Core Issues in jadx-core module regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skylot @pubiqq