Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Try to restore open tabs on file reload #792

Closed
S-trace opened this issue Dec 10, 2019 · 3 comments · Fixed by #793
Closed

[feature] Try to restore open tabs on file reload #792

S-trace opened this issue Dec 10, 2019 · 3 comments · Fixed by #793
Labels
new feature

Comments

@S-trace
Copy link
Contributor

S-trace commented Dec 10, 2019

Hello.

I added a feature to allow jadx-gui to restore open tabs on file reload.
It saves a list of open classes and scroll positions before reopening file and then tries to restore tabs back when file is reopened.
This feature is extremely important for rename function, because file is reloaded after renaming items.
I pushed it to https://github.com/S-trace/jadx/tree/restore_tabs
Could you please review it and allow me to open pull request?

Thank you.
@skylot
Copy link
Owner

skylot commented Dec 10, 2019

@S-trace nice feature! Open PR and I will merge it

@S-trace S-trace mentioned this issue Dec 10, 2019
Merged
@S-trace
Copy link
Contributor Author

S-trace commented Dec 10, 2019

Thank you.
I opened the pull request #793 for this.

The only problem with current implementation is reset of the jumps history (after file reload jumps history is lost).
I don't know, is saving old jump history saint or not. Could you please take look on this problem?

skylot pushed a commit that referenced this issue Dec 10, 2019
@S-trace @skylot
feat(gui): reopened tabs on file reload (PR #793 #792)
78eed86 
* Add getRealFullName() to ClassNode and JavaClass and searchJavaClassByRealName() to JadxWrapper

Those methods is like getFullName() and searchJavaClassByClassName(), but for class names without aliases.
It is necessary for renaming classes/methods/fields.

* MainWindow: Try to restore open tabs on deobfuscation toggle

Restore open tabs if possible when user toggles deobfuscation mode.
Try to scroll to the position before toggling deobfuscation mode (may be not exact cause of the comments).
@skylot
Copy link
Owner

skylot commented Dec 10, 2019

@S-trace restore jump history is not hard I will try to fix it later 👍

@anantshri anantshri mentioned this issue Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try to restore opened tabs on file reload
2 participants
@skylot @S-trace