-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logcat output to JadX Debugger #1666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation to the controller.
…tPane. Logcat pane will now autoscroll only if it is already scrolled to the bottom. Debugger exit will now stop logcat as well.
…ormatting of logcat messages.
skylot
approved these changes
Sep 8, 2022
@TheCobraChicken looks good. Thank you for your work 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Logcat output directly into the JadX debugger.
Currently works by running a timer that will call the logcat command every second and parse / store the output in an ArrayList for follow on filtering. I have run into some lagging issues when attempting to display a large number of log messages at once particularly when attempting to display logs for all processes and logcat -c has not been run in a while. I did add the ability to pause the logcat timer and run logcat clear from within JadX to help if there is a huge amount of log messages being generated. Let me know if you think this method is to resource intensive and I can tweak it.
Finishes issue #1411