-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gui): Quick Tabs Optimization #2242
Conversation
I think we can make it independent: new class (JumpsController?) to listen tabs changes and code jumps with ITabsStatesListener, record these jumps into JumpManager, and on back/forward actions calls TabsController methods. One downside here is that we need to use |
(added NavigationController in last commit, sorry for wrong commit message) Anything else that needs refactoring ? |
No, I think all good now. |
And next I trigger some error without exception and spend lots of time debugging it 🤣
|
@Mino260806 please check my changes, I think we can merge this PR 🙂 |
@Mino260806 I will merge this PR. It contains a lot of good changes and fixes. |
Sorry I had no time to check it |
Follow-up to PR #2241
Should we also move
JumpManager
,navBack
andnavForward
to TabsController ? I'm hesitating because it's something particular toTabbedPane