Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skypack fails on code with private fields #364

Open
trusktr opened this issue Oct 27, 2023 · 2 comments
Open

skypack fails on code with private fields #364

trusktr opened this issue Oct 27, 2023 · 2 comments

Comments

@trusktr
Copy link

trusktr commented Oct 27, 2023

Reproduction:

import('https://cdn.skypack.dev/lume/dist/index.js').then(console.log)

Error:

[Package Error] "lume@v0.3.0-alpha.28" could not be built. 
[1/5] Verifying package is valid…
[2/5] Installing dependencies from npm…
[3/5] Building package using esinstall…
Running esinstall...
Failed to load node_modules/lume/dist/core/ChildTracker.js
  Unexpected token (24:8) in lume/dist/core/ChildTracker.js
Install failed.
Install failed.

The reason is #private syntax.

Skypack needs a tooling update.

I wish we had a vanilla ESM server that would never break on syntax.

@JohnRDOrazio
Copy link

I am getting the same error:
https://cdn.skypack.dev/error/build:@liturgical-calendar/components-js@v1.0.7-uYywXwHIoo39BxHXG1Tt

/*
 * [Package Error] "@liturgical-calendar/components-js@v1.0.7" could not be built. 
 *
 *   [1/5] Verifying package is valid…
 *   [2/5] Installing dependencies from npm…
 *   [3/5] Building package using esinstall…
 *   Running esinstall...
 *   Failed to load node_modules/@liturgical-calendar/components-js/dist/CalendarSelect/CalendarSelect.js
 *     Unexpected token (272:4) in @liturgical-calendar/components-js/dist/CalendarSelect/CalendarSelect.js
 *   Install failed.
 *   Install failed.
 *
 * How to fix:
 *   - If you believe this to be an error in Skypack, file an issue here: https://github.com/skypackjs/skypack-cdn/issues
 *   - If you believe this to be an issue in the package, share this URL with the package authors to help them debug & fix.
 *   - Use https://skypack.dev/ to find a web-friendly alternative to find another package.
 */

console.warn("[Package Error] \"@liturgical-calendar/components-js@v1.0.7\" could not be built. \n[1/5] Verifying package is valid…\n[2/5] Installing dependencies from npm…\n[3/5] Building package using esinstall…\nRunning esinstall...\nFailed to load node_modules/@liturgical-calendar/components-js/dist/CalendarSelect/CalendarSelect.js\n  Unexpected token (272:4) in @liturgical-calendar/components-js/dist/CalendarSelect/CalendarSelect.js\nInstall failed.\nInstall failed.");
throw new Error("[Package Error] \"@liturgical-calendar/components-js@v1.0.7\" could not be built. ");
export default null;

Whereas jsdelivr does not pose a problem: https://cdn.jsdelivr.net/npm/@liturgical-calendar/components-js@1.0.7/+esm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants