Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skypack is definitely unmaintained, newer code breaks Skypack. #362

Open
trusktr opened this issue Sep 22, 2023 · 0 comments
Open

Skypack is definitely unmaintained, newer code breaks Skypack. #362

trusktr opened this issue Sep 22, 2023 · 0 comments

Comments

@trusktr
Copy link

trusktr commented Sep 22, 2023

F.e. https://cdn.skypack.dev/lume@0.3.0-alpha.27 currently forwards to https://cdn.skypack.dev/error/build:lume@v0.3.0-alpha.27-XyqUZ0QD4LxUz3lBtzzc, which shows the following error message, and I think it is because EcmasScript #private field syntax that even all browsers today support:

/*
 * [Package Error] "lume@v0.3.0-alpha.27" could not be built. 
 *
 *   [1/5] Verifying package is valid…
 *   [2/5] Installing dependencies from npm…
 *   [3/5] Building package using esinstall…
 *   Running esinstall...
 *   Failed to load node_modules/lume/dist/cameras/PerspectiveCamera.js
 *     Unexpected token (87:4) in lume/dist/cameras/PerspectiveCamera.js
 *   Install failed.
 *   Install failed.
 *
 * How to fix:
 *   - If you believe this to be an error in Skypack, file an issue here: https://github.com/skypackjs/skypack-cdn/issues
 *   - If you believe this to be an issue in the package, share this URL with the package authors to help them debug & fix.
 *   - Use https://skypack.dev/ to find a web-friendly alternative to find another package.
 */

console.warn("[Package Error] \"lume@v0.3.0-alpha.27\" could not be built. \n[1/5] Verifying package is valid…\n[2/5] Installing dependencies from npm…\n[3/5] Building package using esinstall…\nRunning esinstall...\nFailed to load node_modules/lume/dist/cameras/PerspectiveCamera.js\n  Unexpected token (87:4) in lume/dist/cameras/PerspectiveCamera.js\nInstall failed.\nInstall failed.");
throw new Error("[Package Error] \"lume@v0.3.0-alpha.27\" could not be built. ");
export default null;
miharekar added a commit to miharekar/visualizer that referenced this issue Mar 30, 2024
Skypack seems abandoned:
- skypackjs/skypack-cdn#365
- skypackjs/skypack-cdn#362

importmap-rails switched logic to always download: rails/importmap-rails#217

But it doesn't work for complex bigger packages. There's a WIP PR to address this: rails/importmap-rails#235

So I decided to use the new rails-importmap approach where I can, and switch to jsdelivr where I have to.

I've pinned to major versions and jsdelivr should take care of everything else. I've also updated the rake task to check for major version updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant