Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCP] Fine-grained failure reasons in thesky check for SCP #2015

Closed
romilbhardwaj opened this issue Jun 3, 2023 · 3 comments
Closed

[SCP] Fine-grained failure reasons in thesky check for SCP #2015

romilbhardwaj opened this issue Jun 3, 2023 · 3 comments
Labels
good first issue Good for newcomers Stale

Comments

@romilbhardwaj
Copy link
Collaborator

Current output if ~/.scp/scp_credential does not exist:

  SCP: disabled
    Reason: Failed to access SCP with credentials. To configure credentials, see: https://cloud.samsungsds.com/openapiguide
    Generate API key and add the following line to ~/.scp/scp_credential:
      access_key = [YOUR API ACCESS KEY]
      secret_key = [YOUR API SECRET KEY]
      project_id = [YOUR PROJECT ID]

If I don't have a ~/.scp/scp_credential file, the Reason message on sky check should be descriptive and tell me exactly that file does not exist. Similarly, if the credentials are incorrect, we should re-word this to say credentials are invalid.

We should catch each exception here separately and print out nice reasons on how to fix:

skypilot/sky/clouds/scp.py

Lines 285 to 293 in d022512

except (AssertionError, KeyError, scp_utils.SCPClientError):
return False, ('Failed to access SCP with credentials. '
'To configure credentials, go to:\n'
' https://cloud.samsungsds.com/openapiguide\n'
' to generate API key and add the line\n'
' access_key = [YOUR API ACCESS KEY]\n'
' secret_key = [YOUR API SECRET KEY]\n'
' project_id = [YOUR PROJECT ID]\n'
' to ~/.scp/scp_credential')

The R2 check implementation may be a good reference.

@romilbhardwaj romilbhardwaj added the good first issue Good for newcomers label Jun 3, 2023
@ksasi
Copy link
Contributor

ksasi commented Jun 14, 2023

We see similar output even for Lambda

Lambda: disabled
    Reason: Failed to access Lambda Cloud with credentials. To configure credentials, go to:
      https://cloud.lambdalabs.com/api-keys
    to generate API key and add the line
      api_key = [YOUR API KEY]
    to ~/.lambda_cloud/lambda_keys

ksasi added a commit to ksasi/skypilot that referenced this issue Jun 18, 2023
ksasi added a commit to ksasi/skypilot that referenced this issue Jun 18, 2023
romilbhardwaj pushed a commit that referenced this issue Jun 28, 2023
* Fix for issue - [Storage] Make sky storage delete parallel #1990

* [Storage] Make sky storage delete parallel #1990 #2058

* Updated test for deleting multiple buckets

* Fix for issue #2015

* Revert "Fix for issue #2015"

This reverts commit c28e4ec.

* Moved storage object creation to a fixture (tmp_multiple_scratch_storage_obj)

* Updated test_multiple_buckets_creation_and_deletion, tmp_multiple_scratch_storage_obj to account for multiple store types

* Added pytest.mark.xdist_group to test_multiple_buckets_creation_and_deletion test to run all parameterized tests serially
@github-actions
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 13, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Stale
Projects
None yet
Development

No branches or pull requests

2 participants