-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ResourceHandle
semantics
#1481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the quick fix @iojw!
For smoke tests, let's try to use spot TPU pod to save some costs?
as we have some free quota in |
@infwinston Updated! |
This fixes the following issues with the new
ResourceHandle
introduced in #1380.sky status -r
will not update them to the latest version, causing the IPs for these clusters to be queried on each call which is slow. This PR updates it such that these clusters will be updated to the latest version on refresh.Theexternal_ips
andinternal_ips
methods should always return a list as that is what is expected by the rest of the codeTested: