Remove unsafe colorama.init

[infwinston]

Fixes #1694.
After removing the init(), I was trying to add

from colorama import just_fix_windows_console
just_fix_windows_console()

as suggested by https://github.com/tartley/colorama#initialisation

But this function only introduced after 0.4.5 and we pin colorama<0.4.5 because it conflicts with aws-cli for some reason.

skypilot/sky/setup_files/setup.py

Line 73 in e4b99e0

'colorama<0.4.5',

Related issue: #1323
Is this still the case after we upgrade ray version? @Michaelvll

or is it safe to add colorama.init() in sky/__init__.py?

Tested (run the relevant ones):

• Any manual or new tests for this PR (please specify below)
• All smoke tests: pytest tests/test_smoke.py
• Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
• Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

[infwinston]

@romilbhardwaj Could you please help testing if with this branch, whether the color will show up on windows?

[Michaelvll]

Thank you for submitting the PR @infwinston! The older version of awscli requires a colorama before 0.4.5. Can we try to install a later awscli and launch an aws VM to see if the problem still exists?

[infwinston]

Thanks @Michaelvll . looks like aws-cli also pins the colorama version before 0.4.5..
https://github.com/aws/aws-cli/blob/develop/setup.py#L31

I launched a windows VM to test what's going on without init()
I can reproduce the color issue. however, it seems to me that after import sky the issue has gone.
I think that's because some of the other packages we import already run colorama.init() so we don't need to call it again.
does it make sense to you?

[Michaelvll]

Thanks for the investigation @infwinston! The changes look good to me.