Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spot] Fix spot for new user #1798

Merged
merged 1 commit into from
Mar 20, 2023
Merged

[Spot] Fix spot for new user #1798

merged 1 commit into from
Mar 20, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Mar 20, 2023 •
edited
Loading

To reproduce:

  1. rm -r ~/.sky/spot_controller
  2. sky spot launch echo hi

Tested (run the relevant ones):

  • Any manual or new tests for this PR (please specify below)
    • snippets above
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

romilbhardwaj
romilbhardwaj approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast fix @Michaelvll! Just tested and it's working for me.

@Michaelvll Michaelvll merged commit 14cb4b5 into master Mar 20, 2023
@Michaelvll Michaelvll deleted the fix-spot-folder-creation branch March 20, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romilbhardwaj romilbhardwaj romilbhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michaelvll @romilbhardwaj