Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Faster cloud-init for disabling unattended-upgrade #1954

Merged
merged 2 commits into from
May 12, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 12, 2023

The previous way to disable the unattended-upgrade significantly increase the provisioning time of AWS cluster, due to the apt remove run in the beginning of the system. We now switch to the configuration method which will reduce the provision time from 3m40s to 2m30s with time sky launch -c min-aws --cloud aws -y

Tested (run the relevant ones):

@Michaelvll Michaelvll changed the title [AWS] Faster cloud-init for disable unattended-upgrade [AWS] Faster cloud-init for disabling unattended-upgrade May 12, 2023
- echo 'APT::Periodic::Enable "0";' > /etc/apt/apt.conf.d/10cloudinit-disable
- apt-get -y purge update-notifier-common ubuntu-release-upgrader-core landscape-common unattended-upgrades
- echo "Removed APT" | systemd-cat
write_files:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a note for the future: some ulimit command in our setup_commands can possibly be moved to cloud-init time as well? E.g., https://github.com/lework/kainstall/blob/7a59178afe187f05cc4d78ce63947589f69fc9bd/kainstall-ubuntu.sh#L351-L376

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! We should do that, that can also help us get rid of many prlimit commands for ray. Filed an issue #1957

@Michaelvll Michaelvll merged commit 54494d6 into master May 12, 2023
@Michaelvll Michaelvll deleted the aws-cloud-init branch May 12, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants