[Spot] Switch to download and streaming for the failed user program logs #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
changed the title
5 tasks
sky/spot/controller.py
Outdated
| @@ -74,6 +75,36 @@ def __init__(self, job_id: int, dag_yaml: str, | |||
| job_id_env_vars) | |||
| task.update_envs(task_envs) | |||
|
|
|||
| def _download_log_and_stream(self, handle): | |||
| """ Download the logs from spot cluster, and stream them | |||
There was a problem hiding this comment.
Suggested change
| """ Download the logs from spot cluster, and stream them | |
| """Downloads the logs of the latest job of a spot cluster, and streams them. |
There was a problem hiding this comment.
Have to reduce the number of words a bit to fit it in one line. Modified. Thanks!
sky/spot/controller.py
Outdated
| log_dir = list(log_dirs.values())[0] | ||
|
|
||
| # Print the logs to the console. | ||
| for log_file in os.listdir(log_dir): |
There was a problem hiding this comment.
Q: what is the layout of ~/sky_logs/spot_jobs/? Does it have a subdir or a file per spot job id (that has failed)? Wondering why we're printing every *.log file here.
There was a problem hiding this comment.
Each spot job will have a subdir under the ~/sky_logs/spot_jobs, and the log_dir here is the folder for that particular job.
We can only print out the run.log under the folder, but I was trying to make sure we don't miss any possible logs in future. Just changed back to run.log for clarity.
concretevitamin
approved these changes
Aug 1, 2023
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2329
This should make the debugging of the user program much easier.
Tested (run the relevant ones):
bash format.shsky spot logs --controller#2329.pytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh