Fix accidentally removed updates to cloud provider #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
changed the title
Michaelvll
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Thanks for adding these changes back @cblmemo! I will force a new nightly build after this PR is merged.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2375 some updates to the cloud provider were accidentally removed. IIUC it is from this commit in which author directly checkout original master, so some updates got removed. This PR fixed this problem.
Tested (run the relevant ones):
bash format.shsky launch -c cbl-test-az --region eastus2 --cloud azure tests/test_yamls/minimal.yamlpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh