[AWS] unset AWS env vars to avoid autoscaler using the incorrect credentials #2442

Michaelvll · 2023-08-21T23:31:59Z

Fixes #2441.

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
- The reproducible code in [AWS] Setting AWS credentials to another account in the env var through /etc/profile.d will cause the cluster in INIT mode #2441
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

sky/templates/aws-ray.yml.j2

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

Michaelvll added 2 commits August 21, 2023 16:21

unset AWS env vars to avoid autoscaler using the incorrect credentials

45fb9d5

add comment

41afc72

Michaelvll marked this pull request as ready for review August 21, 2023 23:47

Michaelvll added the P0 label Aug 21, 2023

Michaelvll requested a review from concretevitamin August 21, 2023 23:47

concretevitamin approved these changes Aug 22, 2023

View reviewed changes

sky/templates/aws-ray.yml.j2 Outdated Show resolved Hide resolved

Update sky/templates/aws-ray.yml.j2

80d5681

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

Michaelvll merged commit ab9daf0 into master Aug 22, 2023
17 checks passed

Michaelvll deleted the correct-aws-credential-for-autoscaler branch August 22, 2023 04:27

Provide feedback