Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Add OPEN_PORTS to unsupported features for kubernetes #2588

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

romilbhardwaj
Copy link
Collaborator

We currently do not support opening ports on Kubernetes clusters. However, it is still picked by the optimizer as a candidate cloud because CloudImplementationFeatures.OPEN_PORTS is not excluded in Kubernetes. This PR fixes that.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • sky launch -c <yaml_with_ports>, it excludes Kubernetes now

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One nit: Why are these lines so long..? Seems like it exceeded our max length (80)?

@romilbhardwaj
Copy link
Collaborator Author

I was wondering the same - I had formatted it to be different lines but pylint put them in the same line...

@cblmemo
Copy link
Collaborator

cblmemo commented Sep 21, 2023

I was wondering the same - I had formatted it to be different lines but pylint put them in the same line...

IIRC I remembered that you need to add parentheses 🤧some strange pylint behaviour

@romilbhardwaj romilbhardwaj merged commit b1d8c9d into master Sep 22, 2023
18 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_disable_ports branch September 22, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants