-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Examples] add a new example of tabby #2597
[Examples] add a new example of tabby #2597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the exciting demo!!! 🚀 Tried the YAML and it works great 💪🏻. Left several nits ;)
Also, a discussion: There is a lot of introduction content for the skypilot repository, which seems a little bit redundant inside the skypilot repo. Maybe we could remove some of them? cc @Michaelvll for a look 👀
nit: Thanks for the PR! ❤️ |
@cblmemo Sorry for the somewhat late reply, I've been attending KubeCon China for the last few days. I fixed and tested most of what was in the review feedback. Unfortunately, I found a bug in my testing: when I opened the port with I haven't read the source code, so I'm not sure if this phenomenon is unique to Azure or if all clouds have similar issues. Additional context
|
Thanks for reporting that! I tried this YAML with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this tabby example @sunny0826! This is fantastic! Left a question for the toml
file. Otherwise, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Thanks for adding this example @sunny0826 @wsxiaoys! I am going to merge it soon. : ) |
Add a Tabby example to guide users in quickly deploying Tabby on any cloud using SkyPilot.