Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axolotl example #2784

Merged
merged 7 commits into from
Nov 15, 2023
Merged

axolotl example #2784

merged 7 commits into from
Nov 15, 2023

Conversation

manishiitg
Copy link
Contributor

Added example for using axolotl

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is super awesome @manishiitg! Tested it out and both YAMLs work great. Thanks a bunch for sharing.

Made some suggestions, mostly about passing secrets via env vars.

val_set_size: 0.05
output_dir: ./qlora-out

hub_model_id: manishiitg/mhenrichsen-alpaca_2k_test # TODO: Replace with hub model id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like without changing these, training will throw

(axolotl, pid=13280) You don't have the rights to create a model under this namespace
(axolotl, pid=13280)
(axolotl, pid=13280) During handling of the above exception, another exception occurred:
(axolotl, pid=13280)
(axolotl, pid=13280) Traceback (most recent call last):
(axolotl, pid=13280)   File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/huggingface_hub/utils/_errors.py", line 261, in hf_raise_for_status
(axolotl, pid=13280)     response.raise_for_status()
(axolotl, pid=13280)   File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/requests/models.py", line 1021, in raise_for_status
(axolotl, pid=13280)     raise HTTPError(http_error_msg, response=self)
(axolotl, pid=13280) requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://huggingface.co/api/models/manishiitg/mhenrichsen-alpaca_2k_test

It works when I comment it out (default to HF trainer's default behavior).

How about we comment out this line, and add some quick instruction to add to README for changing this string?

Do we want to comment out hf_use_auth_token line too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented this

Comment on lines 18 to 19
hub_model_id: manishiitg/mistral-alpaca_2k_test # TODO: Replace with hub model id
hf_use_auth_token: false # TODO: push as private or public model
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the other comment - should comment out these?

llm/axolotl/axolotl-spot.yaml Show resolved Hide resolved
llm/axolotl/axolotl-spot.yaml Show resolved Hide resolved
llm/axolotl/axolotl-spot.yaml Outdated Show resolved Hide resolved
llm/axolotl/readme.md Outdated Show resolved Hide resolved
llm/axolotl/readme.md Outdated Show resolved Hide resolved
llm/axolotl/readme.md Outdated Show resolved Hide resolved
llm/axolotl/mistral/qlora.yaml Outdated Show resolved Hide resolved
llm/axolotl/mistral/qlora-checkpoint.yaml Outdated Show resolved Hide resolved
manishiitg and others added 6 commits November 15, 2023 14:59
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
@manishiitg
Copy link
Contributor Author

@concretevitamin incorporated comments

@concretevitamin
Copy link
Member

Awesome @manishiitg ! Thanks for contributing this example!

@concretevitamin concretevitamin merged commit e6c690d into skypilot-org:master Nov 15, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants