-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old AWS node provider #2792
Conversation
@Michaelvll I tried to test this PR but find may smoke tests failed due to insufficient quotas. Could you test it for me? I think running smoke tests should be good enough, since these code should not interfere with our current functionality. Thanks! |
…_old_aws_node_provider
Thaanks for submitting this PR @suquark! I am testing the following tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the staled node_providers for AWS @suquark! It seems working nicely and passed all the smoke tests. It should be good to go in. : )
With the new provisioner shipped for a while and no significant issues, now we can consider deprecating the old AWS node provider. In theory this should not break any tests. I still need to run smoke tests to confirm it though.
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh