Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old AWS node provider #2792

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Conversation

suquark
Copy link
Collaborator

@suquark suquark commented Nov 16, 2023

With the new provisioner shipped for a while and no significant issues, now we can consider deprecating the old AWS node provider. In theory this should not break any tests. I still need to run smoke tests to confirm it though.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@suquark
Copy link
Collaborator Author

suquark commented Nov 16, 2023

@Michaelvll I tried to test this PR but find may smoke tests failed due to insufficient quotas. Could you test it for me? I think running smoke tests should be good enough, since these code should not interfere with our current functionality. Thanks!

@Michaelvll
Copy link
Collaborator

Michaelvll commented Jan 16, 2024

Thaanks for submitting this PR @suquark! I am testing the following tests:

  • pytest tests/test_smoke.py
  • bash -i ./tests/backward_compatibility_tests.sh
  • pytest tests/test_smoke.py --aws

@Michaelvll Michaelvll changed the title [WIP] Remove old AWS node provider Remove old AWS node provider Jan 16, 2024
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the staled node_providers for AWS @suquark! It seems working nicely and passed all the smoke tests. It should be good to go in. : )

@Michaelvll Michaelvll merged commit 4c916f6 into master Jan 16, 2024
19 checks passed
@Michaelvll Michaelvll deleted the remove_old_aws_node_provider branch January 16, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants