AWS: make public / private subnet selection robust. #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Dec 15, 2023
There was a problem hiding this comment.
Thanks for making figuring out this issue @concretevitamin! The PR looks mostly good to me. Left several comments.
Michaelvll
approved these changes
Dec 15, 2023
Michaelvll
reviewed
Dec 15, 2023
Michaelvll
approved these changes
Dec 15, 2023
sky/utils/controller_utils.py
Outdated
Comment on lines
351
to
353
| else: | ||
| new_skypilot_config = {} | ||
| common_utils.dump_yaml(f.name, new_skypilot_config) |
There was a problem hiding this comment.
Great catch! Can we remove the entry in the file mounts instead of creating an empty file to save the overhead for uploading the empty file?
Michaelvll
approved these changes
Dec 16, 2023
7 tasks
remyleone
pushed a commit
to remyleone/skypilot
that referenced
this pull request
Dec 26, 2023
* AWS: make public / private subnet selection robust. * Update docs * Fix: handle regions with main route table(s) only * assert * comment * Cache once * format * Add asserts * fix placeholder replacement logic * Minor * Fix bug where we launch a private IP-only VM in a public subnet * Avoid uploading empty config yaml * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes two issues from before
privateis a substr in its name tag)subnet.map_public_ip_on_launchset to False.This PR uses a more robust method to test if a subnet is public:
igw-*)igw-*)Tested:
aws.vpc_name: skypilot-vpcand correspondinguse_internal_ips,ssh_proxy_commandaws.vpc_name: skypilot-vpcand correspondinguse_internal_ips,ssh_proxy_commandSpeed
for i in $(seq 3); do sky launch --cloud aws -i0 --down --use-spot --region us-east-1 -y >log-${i}; doneNo VPC/private IP settings
sky launch -c dbg --cloud aws -i0 --down --use-spot -y --region ap-northeast-3skypilot-vpcroute tables (us-east-2)sky launch --cloud aws -i0 --down --use-spot -y --region us-east-2sky launch --gpus A100:8 --cloud aws -i0 --down --use-spot -yWith
aws.vpc_name: skypilot-vpconlysubnet.map_public_ip_on_launchset to False.sky launch --cloud aws -i0 --down --use-spot -y --region us-east-2With
aws.vpc_name: skypilot-vpcand correspondinguse_internal_ips,ssh_proxy_commandsky launch --cloud aws -i0 --down --use-spot -y --region us-east-2sky launch --cloud aws -i0 --down --gpus A10G --use-spot -yTested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh