-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 1175 - improve YAML error reporting with detailed debugging info #3040
Fix Issue 1175 - improve YAML error reporting with detailed debugging info #3040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Shrinandan-N!
test.yaml
Outdated
name: Test Configuration | ||
details: | ||
- item1: value1 | ||
- item2 value2 # Missing colon | ||
- item3: value3 | ||
incorrect_indentation # This line is incorrectly indented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove this test YAML from the PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Shrinandan-N! LGTM!
Added additional debug information to the YAML error reporting in
_check_yaml()
functioncli.py
. Formatted error reporting to be readable.Tested (run the relevant ones):
bash format.sh