Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 1175 - improve YAML error reporting with detailed debugging info #3040

Merged

Conversation

Shrinandan-N
Copy link
Contributor

Added additional debug information to the YAML error reporting in _check_yaml() function cli.py. Formatted error reporting to be readable.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Tested detailed error reporting with a newly created test.yaml file that had syntax errors

Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shrinandan-N!

sky/cli.py Outdated Show resolved Hide resolved
test.yaml Outdated
Comment on lines 1 to 6
name: Test Configuration
details:
- item1: value1
- item2 value2 # Missing colon
- item3: value3
incorrect_indentation # This line is incorrectly indented
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove this test YAML from the PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

Shrinandan-N and others added 2 commits January 29, 2024 11:04
Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com>
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shrinandan-N! LGTM!

@romilbhardwaj romilbhardwaj merged commit d84992b into skypilot-org:master Jan 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants