[Provisioner] Fix Azure disk tier explicitly shown in resources str #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Feb 1, 2024
sky/clouds/azure.py
Outdated
Comment on lines
299
to
310
| def _failover_disk_tier() -> Optional[resources_utils.DiskTier]: | ||
| # Failover disk tier. | ||
| all_tiers = list(reversed(resources_utils.DiskTier)) | ||
| start_index = all_tiers.index( | ||
| Azure._translate_disk_tier(r.disk_tier)) | ||
| while start_index < len(all_tiers): | ||
| disk_tier = all_tiers[start_index] | ||
| ok, _ = Azure.check_disk_tier(r.instance_type, disk_tier) | ||
| if ok: | ||
| return disk_tier | ||
| start_index += 1 | ||
| return None |
There was a problem hiding this comment.
Does this mean a user specifying --disk-tier medium may get an instance with disk_tier low?
There was a problem hiding this comment.
Good point! We should only do failover if the disk tier is None or BEST. Just pushed a commit to fix that.
There was a problem hiding this comment.
Just re-run every tests and passed
Michaelvll
approved these changes
Feb 2, 2024
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
Tested (run the relevant ones):
bash format.shsky launch -t Standard_D8_v5 --disk-tier mediumand correctly throws an errorpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh