Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Suppress azure logs when opening ports #3084

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Feb 5, 2024

On the latest master branch when we provisioned an Azure cluster w/ ports, it printed out a lots of logs and corrupted the CLI. This PR fixed the issue.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch --cloud azure --ports 8000 and no extra logs printed
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating and fixing this @cblmemo! LGTM.

@cblmemo cblmemo merged commit 872d969 into master Feb 6, 2024
19 checks passed
@cblmemo cblmemo deleted the suppress-azure-logs branch February 6, 2024 00:59
@cblmemo cblmemo mentioned this pull request May 23, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants