[Serve] Allow purging controller for identity mismatch #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Feb 5, 2024
|
Thanks @Michaelvll! Will merge after doing an e2e test when #3043 is merged to make sure it works for k8s. |
romilbhardwaj
added a commit
that referenced
this pull request
Feb 15, 2024
romilbhardwaj
added a commit
that referenced
this pull request
May 8, 2024
* playing around * wip with hacks * wip refactor get_endpoints * working get_endpoints * wip * fixed circular import * Working for ingress and loadbalancer svc * lint * add purging from #3094 * Use local catalog on the controller too * use externalip if available * add dshm_size_limit * optimize dependency installation * Add todo * optimize ingress * fix * fix * remove autostop timing * Fix URLs for raw IP:ports * fixes * wip * SA wip * Allow use of service accounts through remote_identity field * Make purge work for no clusters in kubeconfig * Handle ingress namespace not present * setup optimizations and critical SA key fix * fix docs * fix docs * Add support for skypilot.co/external-ip annotation for ingress * Remove dshm_size_limit * Undo kind changes * Update service account docs * minor docs * update comment * is_same_cloud to cloud_in_list * refactor query_ports to use head_ip * autodown + http prefixing in callers * fix ssh key issues when user hash is reused * linting * lint * lint, HOST_CONTROLLERS * add serve smoke tests for k8s * disallow file_mounts and workdir if no storage cloud is enabled * minor * lint * update fastchat to use --host 127.0.0.1 * extend timeout * docs comments * rename to port * add to core.py * docstrs * add docs on exec based auth * expand elif * add lb comment * refactor * refactor * fix docs build * add PODIP mode support * make ssh services optional * nits * Revert "make ssh services optional" This reverts commit 87d4d25. * Revert "add PODIP mode support" This reverts commit 750d4d4. * nits * use 0.0.0.0 when on k8s; use common impl for other clouds * return dict instead of raising errors in core.endpoints() * lint * merge fixes * merge fixes * merge fixes * lint * fix smoke tests * fix smoke tests * comment * add enum for remote identity * lint * add skip_status_check * remove zone requirement * fix timings for test * silence curl download * move jq from yaml to test_minimal * move jq from yaml to test_minimal
romilbhardwaj
added a commit
that referenced
this pull request
May 8, 2024
* playing around * wip with hacks * wip refactor get_endpoints * working get_endpoints * wip * fixed circular import * Working for ingress and loadbalancer svc * lint * add purging from #3094 * Use local catalog on the controller too * use externalip if available * add dshm_size_limit * optimize dependency installation * Add todo * optimize ingress * fix * fix * remove autostop timing * Fix URLs for raw IP:ports * fixes * wip * SA wip * Allow use of service accounts through remote_identity field * Make purge work for no clusters in kubeconfig * Handle ingress namespace not present * setup optimizations and critical SA key fix * fix docs * fix docs * Add support for skypilot.co/external-ip annotation for ingress * Remove dshm_size_limit * Undo kind changes * Update service account docs * minor docs * update comment * is_same_cloud to cloud_in_list * refactor query_ports to use head_ip * autodown + http prefixing in callers * fix ssh key issues when user hash is reused * linting * lint * lint, HOST_CONTROLLERS * add serve smoke tests for k8s * disallow file_mounts and workdir if no storage cloud is enabled * minor * lint * update fastchat to use --host 127.0.0.1 * extend timeout * docs comments * rename to port * add to core.py * docstrs * add docs on exec based auth * expand elif * add lb comment * refactor * refactor * fix docs build * add PODIP mode support * make ssh services optional * nits * Revert "make ssh services optional" This reverts commit 87d4d25. * Revert "add PODIP mode support" This reverts commit 750d4d4. * nits * use 0.0.0.0 when on k8s; use common impl for other clouds * return dict instead of raising errors in core.endpoints() * lint * merge fixes * merge fixes * merge fixes * lint * fix smoke tests * fix smoke tests * comment * add enum for remote identity * lint * disable autostop for kubernetes * add skip_status_check * remove zone requirement * fix timings for test * silence curl download * move jq from yaml to test_minimal * move jq from yaml to test_minimal * add assert * lint * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3061. Allows purging of serve controller if cluster identity mismatch happens (common on k8s).
Still shows the prompt and requires user to enter 'delete'.
Blocked on #3093 and #3043 for full functionality on k8s.
bash format.sh