[GCP] Get rid of backup config file and fix identity check for service acocunt #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3171
We also removed the backup config file, as we got rid of ray autoscaler and will not have the problem where the GCP credential will be overwritten on the remote cluster.
Tested (run the relevant ones):
bash format.shsky spot launch -n test-service --cloud gcp --cpus 2 echo hiwith spot controller on AWSsky spot launch -n test-service --cloud gcp --cpus 2 echo hiwith spot controller on GCPsky launch -c test-fm --cloud gcp ./examples/using_file_mounts.yamlwith private buckets, without config set and login to check the GCP credentials used to check whether backup works.pytest tests/test_smoke.py --gcppytest tests/test_smoke.py::test_fill_in_the_namepytest tests/test_smoke.py::test_file_mounts --gcpwith private buckets involvedbash tests/backward_comaptibility_tests.sh