Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RunPod] Fix multi-gpu provisioning. #3291

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

concretevitamin
Copy link
Member

Fixes #3146, #3289.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch --gpus RTXA6000:2 --cloud runpod --down -- nvidia-smi
    • sky launch --gpus RTXA6000 --cloud runpod --down -- nvidia-smi
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @concretevitamin! LGTM.

@concretevitamin concretevitamin merged commit d3fc69e into master Mar 9, 2024
19 checks passed
@concretevitamin concretevitamin deleted the runpod-multigpu branch March 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants