[Serve] Expose detailed replica failure reason and rename service failure to crash loop #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
reviewed
Apr 2, 2024
sky/serve/replica_managers.py
Outdated
| if self.first_ready_time is None: | ||
| # readiness probe is not executed yet, but a scale down is | ||
| # triggered. | ||
| return serve_state.ReplicaStatus.SHUTTING_DOWN | ||
| if self.first_ready_time == -1: | ||
| # initial delay seconds exceeded | ||
| return serve_state.ReplicaStatus.FAILED | ||
| return serve_state.ReplicaStatus.FAILED_PROBE |
There was a problem hiding this comment.
Should we use sth like FAILED_INITIALIZATION to diff w/ the following
|
Moved to #3411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the failure reason for serving more visible and aligns with Kubernetes behavior when the underlying replicas fail.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py --servepytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh