Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] Add provision_timeout to config for k8s provisioning #3415

Merged
merged 6 commits into from
Apr 4, 2024
Merged

[k8s] Add provision_timeout to config for k8s provisioning #3415

merged 6 commits into from
Apr 4, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

Autoscaling clusters or clusters with admission control may require tweaking the provisioning timeout. This PR adds support for that by adding kubernetes.provision_timeout field to ~/.sky/config.yaml.

  • Code formatting: bash format.sh
  • Manual sky launch with and without kubernetes.provision_timeout in config.yaml

Michaelvll
Michaelvll approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @romilbhardwaj! LGTM

docs/source/reference/config.rst Show resolved Hide resolved
sky/clouds/kubernetes.py Outdated Show resolved Hide resolved
sky/provision/kubernetes/instance.py Outdated Show resolved Hide resolved
@romilbhardwaj romilbhardwaj merged commit c2a3008 into master Apr 4, 2024
20 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_timeout branch April 4, 2024 01:59
@romilbhardwaj romilbhardwaj mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romilbhardwaj @Michaelvll