Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paperspace] hotfix stop #3418

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[Paperspace] hotfix stop #3418

merged 1 commit into from
Apr 4, 2024

Conversation

asaiacai
Copy link
Contributor

@asaiacai asaiacai commented Apr 4, 2024 •
edited
Loading

Resolves #3416

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)

sky stop now runs properly for Paperspace VMs

sky launch --cloud paperspace -c test
sky stop test

Michaelvll
Michaelvll approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @asaiacai! LGTM

@Michaelvll Michaelvll merged commit 495140e into skypilot-org:master Apr 4, 2024
20 checks passed
@asaiacai asaiacai deleted the paperpatch branch April 4, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Paperspace] Bug in stopping instance
2 participants
@asaiacai @Michaelvll