[Core/UX] Add Job API and support managed job (both on-demand and spot) #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cblmemo
approved these changes
May 4, 2024
There was a problem hiding this comment.
Thanks for this great work @Michaelvll !! It looks awesome to me. Left some nits and it should be ready to go! 🚀
docs/source/images/job-dashboard.png
Outdated
There was a problem hiding this comment.
why is the job 13, 14 not contains any [spot]/[On-demand] suffixes? Does that means it not require any special resources?
There was a problem hiding this comment.
We do not add the suffix for On-Demand only request for simplicity, and add the suffix for all other cases. Wdyt?
sky/utils/controller_utils.py
Outdated
Comment on lines
381
to
382
| # TODO(zhwu): Backward compatibility for the old config for managed | ||
| # job controller. |
Co-authored-by: Tian Xia <cblmemo@gmail.com>
Co-authored-by: Tian Xia <cblmemo@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR require a(We found a way to handle this)sky start -f sky-spot-controller-xxto make the commands likesky spot logs,sky spot queuework.Refer to the latest doc: https://skypilot.readthedocs.io/en/job-api/examples/managed-jobs.html#using-both-spot-and-on-demand-instances
TODO:
sky job queueruns on an old controllerTested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.shsky spot launch -n pipeline tests/test_yamls/pipeline.yaml; this PR:sky job queue;sky job logs;sky job dashboard;sky job cancel;sky job queuebash -i tests/backward_comaptibility_tests.sh 0 7