Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s][GKE] distinguish between h100 and h100-mega on gke #3891

Merged
merged 3 commits into from
Aug 29, 2024
Merged

[k8s][GKE] distinguish between h100 and h100-mega on gke #3891

merged 3 commits into from
Aug 29, 2024

Conversation

asaiacai
Copy link
Contributor

@asaiacai asaiacai commented Aug 29, 2024 •
edited
Loading

This distinguishes between H100 and H100-MEGA-80GB on GKE. Closes #3890

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)

List gpus H100 and H100-MEGA-80GB with sky show-gpus --cloud kubernetes
schedule a skypilot cluster on H100 and H100-MEGA-80GB with sky launch --cloud kubernetes --gpus {H100,H100-MEGA-80GB}
Test output here

@asaiacai asaiacai marked this pull request as ready for review August 29, 2024 05:17
romilbhardwaj
romilbhardwaj approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asaiacai! Fantastic work!

sky/provision/kubernetes/utils.py Outdated Show resolved Hide resolved
asaiacai and others added 2 commits August 28, 2024 23:14
@asaiacai @romilbhardwaj
Update sky/provision/kubernetes/utils.py
a3fdb77 
Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com>
@asaiacai
lint
922ac24
@romilbhardwaj romilbhardwaj added this pull request to the merge queue Aug 29, 2024
@romilbhardwaj
Copy link
Collaborator

Thanks @asaiacai! LGTM.

Merged via the queue into skypilot-org:master with commit 9b3312a Aug 29, 2024
20 checks passed
@asaiacai asaiacai deleted the gke-h100 branch August 29, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romilbhardwaj romilbhardwaj romilbhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[K8s] Distinguish between H100 and H100 Mega
2 participants
@asaiacai @romilbhardwaj