[UX] default to minimal logging (no module/line number/timestamp).

sky/execution.py

@@ -334,7 +334,7 @@ def _execute(
  #
  # Disable the usage collection for this status command.
  env = dict(os.environ,
- **{env_options.Options.DISABLE_LOGGING.value: '1'})
+ **{str(env_options.Options.DISABLE_LOGGING): '1'})
  subprocess_utils.run(
  'sky status --no-show-managed-jobs --no-show-services', env=env)
  print()

sky/optimizer.py

@@ -965,10 +965,10 @@ def _print_candidates(node_to_candidate_map: _TaskToPerCloudCandidates):
  f'Multiple {cloud} instances satisfy '
  f'{acc_name}:{int(acc_count)}. '
  f'The cheapest {candidate_list[0]!r} is considered '
- f'among:\n{instance_list}.\n')
+ f'among:\n{instance_list}.')
  if is_multi_instances:
  logger.info(
- f'To list more details, run \'sky show-gpus {acc_name}\'.')
+ f'To list more details, run: sky show-gpus {acc_name}\n')
 
  @staticmethod
  def _optimize_dag(
@@ -1101,8 +1101,7 @@ def ordinal_number(n):
  Optimizer.print_optimized_plan(graph, topo_order, best_plan,
  total_time, total_cost,
  node_to_cost_map, minimize_cost)
- if not env_options.Options.MINIMIZE_LOGGING.get():
- Optimizer._print_candidates(local_node_to_candidate_map)
+ Optimizer._print_candidates(local_node_to_candidate_map)
  return best_plan
 
 

sky/utils/controller_utils.py

@@ -362,15 +362,15 @@ def shared_controller_vars_to_fill(
  'sky_python_cmd': constants.SKY_PYTHON_CMD,
  }
  env_vars: Dict[str, str] = {
- env.value: '1' for env in env_options.Options if env.get()
+ str(env): str(int(env.get())) for env in env_options.Options
  }
  env_vars.update({
  # Should not use $USER here, as that env var can be empty when
  # running in a container.
  constants.USER_ENV_VAR: getpass.getuser(),
  constants.USER_ID_ENV_VAR: common_utils.get_user_hash(),
  # Skip cloud identity check to avoid the overhead.
- env_options.Options.SKIP_CLOUD_IDENTITY_CHECK.value: '1',
+ str(env_options.Options.SKIP_CLOUD_IDENTITY_CHECK): '1',
  })
  if skypilot_config.loaded():
  # Only set the SKYPILOT_CONFIG env var if the user has a config file.

sky/utils/env_options.py

@@ -5,17 +5,27 @@
 
 class Options(enum.Enum):
  """Environment variables for SkyPilot."""
- IS_DEVELOPER = 'SKYPILOT_DEV'
- SHOW_DEBUG_INFO = 'SKYPILOT_DEBUG'
- DISABLE_LOGGING = 'SKYPILOT_DISABLE_USAGE_COLLECTION'
- MINIMIZE_LOGGING = 'SKYPILOT_MINIMIZE_LOGGING'
+
+ # (env var name, default value)
+ IS_DEVELOPER = ('SKYPILOT_DEV', False)
+ SHOW_DEBUG_INFO = ('SKYPILOT_DEBUG', False)
+ DISABLE_LOGGING = ('SKYPILOT_DISABLE_USAGE_COLLECTION', False)
+ MINIMIZE_LOGGING = ('SKYPILOT_MINIMIZE_LOGGING', True)
  # Internal: this is used to skip the cloud user identity check, which is
  # used to protect cluster operations in a multi-identity scenario.
  # Currently, this is only used in the job and serve controller, as there
  # will not be multiple identities, and skipping the check can increase
  # robustness.
- SKIP_CLOUD_IDENTITY_CHECK = 'SKYPILOT_SKIP_CLOUD_IDENTITY_CHECK'
+ SKIP_CLOUD_IDENTITY_CHECK = ('SKYPILOT_SKIP_CLOUD_IDENTITY_CHECK', False)
+
+ def __init__(self, env_var, default):
+ self.env_var = env_var
+ self.default = default
+
+ def __repr__(self) -> str:
+ return self.env_var
 
  def get(self):
  """Check if an environment variable is set to True."""
- return os.getenv(self.value, 'False').lower() in ('true', '1')
+ return os.getenv(self.env_var,
+ str(self.default)).lower() in ('true', '1')