Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Examples] Add env vars to deepspeed example #3981

Merged
merged 3 commits into from
Sep 27, 2024
Merged

[Examples] Add env vars to deepspeed example #3981

merged 3 commits into from
Sep 27, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

Adds example for how to pass environment variables to deepspeed jobs.

Michaelvll
Michaelvll approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @romilbhardwaj! Looks good to me.

examples/deepspeed-multinode/sky.yaml Show resolved Hide resolved
@romilbhardwaj romilbhardwaj added this pull request to the merge queue Sep 27, 2024
Merged via the queue into master with commit 836c5cd Sep 27, 2024
20 checks passed
@romilbhardwaj romilbhardwaj deleted the examples_deepspeed_envs branch September 27, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romilbhardwaj @Michaelvll