-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serve] Refactor to Fix Type Checking Errors #3999
Conversation
fb0081e
to
42c2c4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andylizf Thanks for the refactor! This mostly looks good to me. Left some nits
Co-authored-by: Tian Xia <cblmemo@gmail.com>
Co-authored-by: Tian Xia <cblmemo@gmail.com>
Co-authored-by: Tian Xia <cblmemo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix @andylizf ! Left one last nit and after that it should be ready to go 🙌
Co-authored-by: Tian Xia <cblmemo@gmail.com>
This reverts commit b7f3eb9.
This PR refactors multiple files within the Serve module to address type-checking errors and improve type annotations. Key changes include:
aiohttp.ClientTimeout
in load_balancer.py to prevent timeouts.str
rather thanstr | Path
using helper functions.Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh