Revert "[UX] default to minimal logging (no module/line number/timestamp)." #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amp). (#…" This reverts commit b96a5b4.
Michaelvll
approved these changes
Sep 26, 2024
asaiacai
added a commit
to asaiacai/skypilot
that referenced
this pull request
Sep 27, 2024
* [LLM] Update qwen examples (skypilot-org#3957) * update qwen examples * Fix misalign * Qwen 2.5 support (skypilot-org#3959) * Update qwen example for 2.5 release * Add support for qwen 2.5 example * Qwen 2.5 k8s (skypilot-org#3960) * Update qwen example for 2.5 release * Add support for qwen 2.5 example * add kubernetes * Integrating the Yi series models (skypilot-org#3958) * Add files via upload * Update and rename qwen2-7b.yaml to yi15-6b.yaml * Add files via upload * Update yi15-9b.yaml * Update yi15-34b.yaml * Update yi15-6b.yaml * Add files via upload * Update yicoder-1_5b.yaml * Update yicoder-9b.yaml * Add files via upload * Update yi15-34b.yaml * Update yi15-6b.yaml * Update yi15-9b.yaml * Update yicoder-1_5b.yaml * Update yicoder-9b.yaml * [Test] Fix Smoke Test `test-skyserve-fast-update` (skypilot-org#3956) * init * add newline * [LLM] Add Qwen2-VL multimodal example (skypilot-org#3961) Add multimodal example * Update README.md (skypilot-org#3969) * Add files via upload * Update and rename qwen2-7b.yaml to yi15-6b.yaml * Add files via upload * Update yi15-9b.yaml * Update yi15-34b.yaml * Update yi15-6b.yaml * Add files via upload * Update yicoder-1_5b.yaml * Update yicoder-9b.yaml * Add files via upload * Update yi15-34b.yaml * Update yi15-6b.yaml * Update yi15-9b.yaml * Update yicoder-1_5b.yaml * Update yicoder-9b.yaml * Update README.md * [Core] Admin policy enforcement plugin (skypilot-org#3966) * support policy hook * test task labels * Add test for policy that sets labels * Fix comment * format * use -e to make test related files visible * Add config.rst * Fix test * fix config rst * Apply policy to service * add policy for serving * Add docs * fix * format * Update interface * fix * Fix * fix * Fix test config * Fix mutated config * fix * Add policy doc * rename * minor * Add additional arguments for autostop * fix mypy * format * rejected message * format * Update sky/utils/policy_utils.py Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update sky/utils/policy_utils.py Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Fix * Update examples/admin_policy/example_policy/example_policy/__init__.py Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update docs/source/reference/config.rst Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Address comments * format * changes in examples * Fix enforce autostop * Fix autostop enforcement * fix test * Update docs/source/cloud-setup/policy.rst Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update sky/admin_policy.py Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update sky/admin_policy.py Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * wip * Update docs/source/cloud-setup/policy.rst Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update docs/source/cloud-setup/policy.rst Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update docs/source/cloud-setup/policy.rst Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * fix * fix * fix * Use sky.status for autostop * update policy * Update docs/source/cloud-setup/policy.rst Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * fix policy.rst * Add comment * Fix logging * fix CI * Update docs/source/cloud-setup/policy.rst Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Use sphnix inline code * Add comment * fix skypilot config file mounts for jobs and serve --------- Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * [k8s] Autodown Serve controller on Kubernetes (skypilot-org#3984) * Add autodown for skyserve on k8s * lint * [Tests] Add missing changes from skypilot-org#3966 for fast service update test (skypilot-org#3976) Use wget instead of git clone for faster downloading * [Paperspace] add A4000, P4000, GPU+ (skypilot-org#3991) add A4000, P4000, GPU+ * [Docs] Fix highlighting in code block (skypilot-org#3994) Fix highlighting in code block Fixes skypilot-org#3993 * [LLM] Llama 3.2 guide (skypilot-org#3990) * Add llama 3.2 example * update * length * fix * update * update cpus limit * Use 11B instead for better performance * update * update * Add link * Fix reference * Fix vllm version * Update llm/llama-3_2/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update llm/llama-3_2/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update llm/llama-3_2/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update llm/llama-3_2/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Fix title * news * no need to pin transformers * remove cover photo for now --------- Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * [k8s] Add cluster attributes(autodown, idle-minutes-to-autostop) as annotations to the pod (skypilot-org#3870) * add autodown annotations to the k8s pod * revert kubernetes ray template * revert backend_utils from invasive approach * nit * revert from invasive approaches * revert * updated approach * nit * nit * Use constant to represent idle_minutes_to_autostop for cancellation * revert using constants for cancel * nit * nit * add smoke tests * Update sky/provision/kubernetes/utils.py Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com> * fix comments * nit * remove loops and annotate one by one * format * update with autodown annotation with context * format --------- Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com> * [Examples] Add airflow example (skypilot-org#3982) * Airflow example * Airflow example * Airflow example * Airflow example * wip * Update airflow examples * Update airflow examples * Update airflow examples * Add to readme * Add to readme * Add to readme * lint * updates * less salesy * comments * comments * comments * [UX] default to minimal logging (no module/line number/timestamp). (skypilot-org#3980) * [UX] default to minimal logging (no module/line number/timestamp). * Fix mypy. * Fix typing * Update sky/utils/env_options.py Co-authored-by: Tian Xia <cblmemo@gmail.com> * Update sky/utils/env_options.py Co-authored-by: Tian Xia <cblmemo@gmail.com> * Account for debug flag. * Remove prefixes from docs. --------- Co-authored-by: Tian Xia <cblmemo@gmail.com> * Revert "[UX] default to minimal logging (no module/line number/timestamp)." (skypilot-org#4003) Revert "[UX] default to minimal logging (no module/line number/timestamp). (#…" This reverts commit b96a5b4. * [Docs] Clarify k8s private registry usage in docs (skypilot-org#3998) * Clarify k8s private registry auth in docs. * comments * [Docs] Various polishing. (skypilot-org#4002) * [Docs] Various polishing. * update * Reword. * lint --------- Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com> Co-authored-by: Haijian Wang <130898843+Haijian06@users.noreply.github.com> Co-authored-by: Tian Xia <cblmemo@gmail.com> Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> Co-authored-by: Romil Bhardwaj <romil.bhardwaj@berkeley.edu> Co-authored-by: Andy Lee <andylizf@outlook.com> Co-authored-by: landscapepainter <34902420+landscapepainter@users.noreply.github.com> Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3980
Reverting for