Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] AWS Neuron Accelerator Example. #4020

Merged
merged 6 commits into from
Sep 30, 2024
Merged

[Examples] AWS Neuron Accelerator Example. #4020

merged 6 commits into from
Sep 30, 2024

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Sep 29, 2024

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this example @cblmemo! Left a few comments.

examples/neuron/inferentia.yaml Outdated Show resolved Hide resolved
examples/neuron/inferentia.yaml Outdated Show resolved Hide resolved
sky/clouds/aws.py Outdated Show resolved Hide resolved
@cblmemo
Copy link
Collaborator Author

cblmemo commented Sep 30, 2024

@Michaelvll Resolved all comments. PTAL again!

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this example @cblmemo! LGTM

@@ -0,0 +1,62 @@
resources:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call this folder aws-neuron?

@cblmemo cblmemo added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit e437e96 Sep 30, 2024
20 checks passed
@cblmemo cblmemo deleted the inf-tri-example branch September 30, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants