-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s] fix managed job issue on k8s #4357
[k8s] fix managed job issue on k8s #4357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nkwangleiGIT!
if destination is None: | ||
destination = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this!
sky/templates/kubernetes-ray.yml.j2
Outdated
cpu: {{cpus}} | ||
memory: {{memory}}G |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not set limits because we want SkyPilot pods to use any idle CPU cycles instead of being throttled to a specific limit. https://home.robusta.dev/blog/stop-using-cpu-limits
cpu: {{cpus}} | |
memory: {{memory}}G |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let me remove it, maybe we should add this notice to docs somewhere.
Signed-off-by: nkwangleiGIT <nkwanglei@126.com>
b8717ec
to
d92e1bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nkwangleiGIT!
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh