Skip to content

Conversation

@Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Apr 6, 2025

Waiting for #5124 as that enables lambda cloud for available high-end GPU
Let's merge this first

Waiting for vllm to merge this PR: vllm-project/vllm#16104

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

"role": "user",
"content": [
{"type" : "text", "text": "Covert this logo to ASCII art"},
{"type": "image_url", "image_url": {"url": "https://pbs.twimg.com/profile_images/1584596138635632640/HWexMoH5_400x400.jpg"}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pbs.twimg.com/profile_images/1584596138635632640/HWexMoH5_400x400.jpg seems to be a dead link?

@Michaelvll
Copy link
Collaborator Author

Michaelvll commented Apr 6, 2025

llama4.mp4

Adding this video

@Michaelvll Michaelvll marked this pull request as ready for review April 6, 2025 08:41
@Michaelvll Michaelvll requested a review from romilbhardwaj April 6, 2025 18:19
@Michaelvll Michaelvll requested a review from romilbhardwaj April 6, 2025 19:24
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @Michaelvll! 🚀 LGTM, we can incrementally make updates later if needed.

@Michaelvll Michaelvll merged commit 740a6e6 into master Apr 6, 2025
20 checks passed
@Michaelvll Michaelvll deleted the llama4 branch April 6, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants