Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build system: use env var for bazel version in CI #1098

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

zaucy
Copy link
Contributor

@zaucy zaucy commented Dec 13, 2023

  • .bazelversion wasn't being respected in CI
  • also using 6.x instead of a specific version

when I get a chance I'll upgrade to 7 in a different PR

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2c4174) 100.00% compared to head (7427993) 100.00%.
Report is 32 commits behind head on wip.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               wip     #1098   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          150       150           
  Lines        25457     25457           
=========================================
  Hits         25457     25457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* also using 6.x instead of a specific version
@zaucy zaucy force-pushed the fix/bazelisk-version-failure branch from d61116a to 7427993 Compare December 13, 2023 16:35
@zaucy zaucy changed the title build system: rename WORKSPACE.bazel -> WORKSPACE for bazelisk build system: use env var for bazel version in CI Dec 13, 2023
@zaucy zaucy marked this pull request as ready for review December 13, 2023 16:36
@skypjack skypjack changed the base branch from master to wip December 13, 2023 16:42
@skypjack skypjack self-requested a review December 13, 2023 16:42
@skypjack skypjack added the build system requests or issues related to the build system label Dec 13, 2023
@skypjack skypjack self-assigned this Dec 13, 2023
@skypjack
Copy link
Owner

Thank you very much!!! ❤️

@skypjack skypjack merged commit 1fb1027 into skypjack:wip Dec 14, 2023
36 of 40 checks passed
@zaucy zaucy deleted the fix/bazelisk-version-failure branch December 15, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system requests or issues related to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants