Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Enable pip to install pre-releases in the tox dev environments #491

Merged
merged 2 commits into from
Sep 8, 2021
Merged

DEV: Enable pip to install pre-releases in the tox dev environments #491

merged 2 commits into from
Sep 8, 2021

Conversation

rrjbca
Copy link
Contributor

@rrjbca rrjbca commented Sep 7, 2021

Description

Enable pip to install pre-releases in the tox dev environments. Fixes #490 since the scipy-wheels-server only hosts pre-releases and so there are no releases of numpy satisfying scipys dependency on numpy>=1.17.3. Setting pip_pre=True allows pip to install the numpy==1.22.0.dev pre-release resolving the dependency conflict. See compatibility workflow logs on the rrjbca/skypy fork e.g. HERE demonstrating successful execution of the compatibility workflow in the py39-test-dev environment.

Checklist

  • Follow the Contributor Guidelines
  • Write unit tests
  • Write documentation strings
  • Assign someone from your working team to review this pull request
  • Assign someone from the infrastructure team to review this pull request

@rrjbca rrjbca requested a review from a team September 7, 2021 08:27
Lucia-Fonseca
Lucia-Fonseca reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@Lucia-Fonseca Lucia-Fonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is clear however you mention

See compatibility workflow logs on the rrjbca/skypy fork e.g. HERE demonstrating successful execution of the compatibility workflow in the py39-test-dev environment.

and two tests are failing. Does it have to do with the new lines of code?

tox.ini
Comment on lines +96 to +97
pip_pre =
dev: True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between these lines of code or typing the following?

[testenv:dev]
pip_pre = True

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your suggestion doesn't work. It only applies to an environment with the exact name dev

@philipp128
Copy link
Contributor

philipp128 commented Sep 8, 2021 •
edited
Loading

You are mentioning we want to pip install the numpy pre-release numpy==1.22.0.dev but the current release is 1.21. That should satisfy issue #490, shouldn't it? There, the latest required numpy version is >=1.17.3.

@rrjbca
Copy link
Contributor Author

rrjbca commented Sep 8, 2021

and two tests are failing. Does it have to do with the new lines of code?

They are failing because there is no v0.4 release tag on the fork:

error: pathspec 'tags/v0.4' did not match any file(s) known to git

The fact that py39-test-dev is passing should be sufficient to demonstrate that this fix resolves the linked issue of installing dependencies in the dev environments

You are mentioning we want to pip install the numpy pre-release numpy==1.22.0.dev but the current release is 1.21. That should satisfy issue #490, shouldn't it? There, the latest required numpy version is >=1.17.3.

The purpose of this workflow is to test against pre-releases

@rrjbca
Copy link
Contributor Author

rrjbca commented Sep 8, 2021

I have rerun the compatibility workflow on the rrjbca/skypy fork after pushing the v0.4 tag and merging this PR into main. See the logs HERE

The results of the dev tests on both skypyproject/skypy and rrjbca/skypy demonstrate that this PR is sufficient to fix #490. Both "latest" tests will continue to fail until a new release is made incorporating the relevant bugfixes.

philipp128
philipp128 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@philipp128 philipp128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass. Looks good to me.

@rrjbca rrjbca merged commit 6d4e7bb into skypyproject:main Sep 8, 2021
@rrjbca rrjbca deleted the compatibility_pip_pre branch September 8, 2021 13:42
rrjbca added a commit to rrjbca/skypy that referenced this pull request Sep 11, 2021
@rrjbca
DEV: Enable pip to install pre-releases in the tox dev environments (s…
86041bc 
…kypyproject#491)
rrjbca added a commit to rrjbca/skypy that referenced this pull request Sep 18, 2021
@rrjbca
DEV: Enable pip to install pre-releases in the tox dev environments (s…
aa95dec 
…kypyproject#491)
itrharrison added a commit that referenced this pull request Dec 15, 2022
@itrharrison @rrjbca
@ntessore @Lucia-Fonseca @sutieng @philipp128 @Fox-Davidson
MAINT: merge main into module/halos (#581)
3496ac0 
* Update name of default branch to main (#434)

* update mailmap (#432)

* Write all tables to a single FITS/HDF5 file (#425)

* ADR 3: Position sampling and patches of the sky (#422)

* BUG: Raise ImportError if optional dependency speclite is not installed (#437)

* MAINT: Set NumPy latest supported version to 1.20 #440

* Update status badges (#441)

* MAINT: Update Lucia affiliation (#451)

* MAINT: add SIT's information (#450)

* DOC: Fix contributor guidelines link (#449)

Co-authored-by: Richard R <58728519+rrjbca@users.noreply.github.com>
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>

* ENH: Logging for skypy command line script and Pipeline class (#453)

* DOC: Describe speclite filters in documentation (#457)

* ENH: Config syntax for importing objects (#463)

* DOC: List of Features (#456)

* DOC: How to construct config files (#454)

* DOC: Remove docstring examples (#429)

* MAINT: Update Zenodo entry for RPR (#468)

* DOC: Readme updates (#460)

* DOC: Expanded landing page documentation (#228)

* DOC: Inverse transform sampling accuracy warning (#472)

* MAINT: Set astropy latest supported version to 4.2 (#483)

* DOC: zenodo json members update (#481)

* DOC: Ryden04 ellipticity doc missing section (#477)

* MAINT: Update numpy and scipy latest supported versions (#488)

* BUG: Change invalid ecsv datatype from int to uint16 (#485)

* DEV: setuptools==58.0.0 (#493)

Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>

* Add compatibility workflow badge (#487)

* DEV: Enable pip to install pre-releases in the tox dev environments (#491)

* TST: Use tmp_path fixture for temporary files in unit tests (#489)

* BUG: Move handling of context arguments after handling of .depends keyword (#465)

* BLD: Set astropy latest supported version to 4.3 and speclite minversion to 0.14 (#486)

* REV: restore setuptools to latest version on readthedocs (#494)

* DEV: pyparsing<3.0.0 (#500)

* Check new astropy file overwrite error message in logging test (#498)

* REV: restore pyparsing to latest version for doc builds (#501)

* DOC: Update citation file with JOSS paper reference (#496)

* BLD: Set astropy latest supported version to 5.0 (#504)

* BLD: Set python latest supported version to 3.10 (#505)

* BLD: Set numpy latest supported version to 1.22 (#506)

* BLD: Set python oldest supported version to 3.7 (#507)

* DOC: Fix code of conduct link (#508)

* Changed y-label in luminosity function example. (#512)

* BLD: Set scipy latest supported version to 1.8 (#510)

* ENH: Rykoff model of the magnitude uncertainty (#526)

* TST: assert photometric error is numerically close to the analytic value (#545)

* TST: Drop deprecated astropy.tests.helper.raises (#546)

* ENH: compute kcorrect remaining stellar mass (#476)

* compute kcorrect remaining stellar mass

* added test for stellar mass remain

Co-authored-by: Ian Harrison <itrharrison@gmail.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>

* ENH: Logistic completeness function (#521)

* BLD: Set astropy latest supported version to 5.1 (#547)

* BUG: `schechter_smf` callable input and docs (#525)

* DOC: Typo in Rykoff error (#550)

* add Fox's details (#551)

Co-authored-by: Richard R <58728519+rrjbca@users.noreply.github.com>

* BLD: Set numpy latest supported version to 1.23 (#552)

* codestyle fixes

* add six requirement for colossus

* tried to fix docs builds

* update passenv

* rtd configuration

Co-authored-by: Richard R <58728519+rrjbca@users.noreply.github.com>
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: Sut-Ieng Tam <30295725+sutieng@users.noreply.github.com>
Co-authored-by: philipp128 <48715661+philipp128@users.noreply.github.com>
Co-authored-by: Fox Davidson <93545862+Fox-Davidson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucia-Fonseca Lucia-Fonseca Lucia-Fonseca left review comments

@philipp128 philipp128 philipp128 approved these changes

Assignees
No one assigned
Labels
continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility workflow cannot install numpy and scipy nightly wheels
3 participants
@rrjbca @philipp128 @Lucia-Fonseca