enhance snapshot replicator #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrondelez
approved these changes
Oct 9, 2019
iuriaranda
reviewed
Oct 9, 2019
| print response | ||
| except botocore.exceptions.ClientError as e: | ||
| raise Exception("Could not issue delete command: %s" % e) | ||
| if snapshot['SnapshotType'] == 'manual': |
There was a problem hiding this comment.
maybe you can filter out automatic snapshots in the describe_db_snapshots api call?
| raise Exception("Could not issue copy command: %s" % e) | ||
| copied_snaps = target.describe_db_snapshots(SnapshotType='manual', DBInstanceIdentifier=instance)['DBSnapshots'] | ||
|
|
||
| if instance in snapshot_detailts['DBInstanceIdentifier']: |
There was a problem hiding this comment.
I think you can replace this if and the for above by doing this:
if snapshot_detailts['DBInstanceIdentifier'] in instances.split(','):
iuriaranda
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: https://github.com/skyscrapers/q1_6/issues/134