Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use proper json library #156

Closed

Conversation

imanushin
Copy link
Contributor

Replace android library to official one, according to https://stackoverflow.com/a/2611900/185498

@carterpage
Copy link
Member

This doesn't compile because the library doesn't support putting a null into JSONArray.

I'm all for getting off the old vaadin library. But need to be thoughtful about it. This would involve at least a minor version bump. Open to suggestions.

@imanushin
Copy link
Contributor Author

@carterpage , thank you. Let's me do the following:

  1. Add some build (will try to play with github actions)
  2. Start testing during that build. Will check also code coverage and maybe will find some missing spots (hopefully it will work with maven)
  3. Change dependency and check code change required
  4. Return to this thread.

@carterpage
Copy link
Member

Thank you, I'll keep an eye out for it.

@SheheryarAamir
Copy link

@carterpage we are having a conflict in our project with spring-cloud-function (version 4.1.2) transitive dependency org.json. Would it be possible if this can be merged and released in 1.5.2

@carterpage
Copy link
Member

Thanks for your submission. This should be address in #194.

A few more things were needed to make the change, including handling the change of JSONException to a RuntimeException.

@carterpage carterpage closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants