Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.20.5+ Support #5

Merged
merged 3 commits into from
May 19, 2024
Merged

Add 1.20.5+ Support #5

merged 3 commits into from
May 19, 2024

Conversation

DovydasTEDS
Copy link
Contributor

Upgraded Fabric Bootstrap version to handle 1.20.5+ / Java 21
Added detection for 1.20.5+

Tested on my other fork:
https://github.com/TeamTEDS/teds-plus-installer

Added handling for 1.20.5+ (Java 21 needed)
Upgraded Fabric Bootstrap version - Handle 1.20.5+
Copy link
Contributor Author

@DovydasTEDS DovydasTEDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the lines of code. I thought these steps were required to set the Java version>

@Gaming32 Gaming32 linked an issue May 19, 2024 that may be closed by this pull request
@DovydasTEDS
Copy link
Contributor Author

I will test this in a bit.

@DovydasTEDS
Copy link
Contributor Author

Both 1.20.6 and 1.20.4 work with the build. Should be ready to be merged.

@Gaming32 Gaming32 merged commit e628851 into skywardmc:main May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fabric error - Incorrect JDK
2 participants