Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i used DatePicker in ActionSheetPicket-3.0, but app crashed. #65

Closed
jcsla opened this issue Oct 5, 2014 · 6 comments
Closed

i used DatePicker in ActionSheetPicket-3.0, but app crashed. #65

jcsla opened this issue Oct 5, 2014 · 6 comments
Labels

Comments

@jcsla
Copy link

jcsla commented Oct 5, 2014

hello

i used DatePicker in ActionSheetPicket-3.0, but app crashed.

app crashed when i was selected am & pm in DatePicker

am & pm was selected completely, app is not crash

but am & pm wasn't selected completely, app is crash frequently.

@skywinder skywinder added the bug label Oct 6, 2014
@skywinder
Copy link
Owner

Got it. In ActionSheetDatePicker when simultaneously pick am & pm and click done.
Thanks.

@koloritcm
Copy link

Maybe related to the crash I've found as well. I solved it with:

[((UIControl*)self.pickerView) removeTarget:nil action:NULL forControlEvents:UIControlEventAllEvents];

In the deallocmethod of AbstractActionSheetPicker.

The problem was that we didn't remove all targets from the picker on dealloc.

@skywinder
Copy link
Owner

@gunnarblom It works! Thanks a lot! 👍
Fixed in 1.1.20

skywinder added a commit that referenced this issue Oct 13, 2014
@thepelican
Copy link

still not solved in 1.1.20.

Pressing cancel on a normal picker crashes the picker.
[((UIControl*)self.pickerView) removeTarget:nil action:NULL forControlEvents:UIControlEventAllEvents];
this line is the issue

@skywinder skywinder reopened this Oct 13, 2014
@skywinder
Copy link
Owner

@thepelican Thanks for notice!

@skywinder
Copy link
Owner

Fixed in 1.1.21!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants