Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "tag" to AbstractActionSheet #159

Merged
merged 1 commit into from
Apr 6, 2015
Merged

Added "tag" to AbstractActionSheet #159

merged 1 commit into from
Apr 6, 2015

Conversation

Jeepston
Copy link

@Jeepston Jeepston commented Apr 1, 2015

Added a tag property to AbstractActionSheetPicker for cases when there is a need to handle multiple pickers in one View Controller.

@skywinder
Copy link
Owner

Thanks for contribution.
ActionSheetPicker is not optimised to use with multiple instances. So, I don't think, that tag will be useful.
Did you try to run several pickers at once? Can you show me a screenshot, how it looks like?

@Jeepston
Copy link
Author

Jeepston commented Apr 5, 2015

Hi,

they are not visible at the same time. My use case is that I need to select two dates. I have two buttons - "select date 1" and "select date 2". First button shows ActionSheetPicker with tag=1, second - with tag = 2. And then in the delegate of ActionSheetPicker I can determine which label to populate based on ActionSheetPicker tag

@skywinder
Copy link
Owner

@Jeepston ok, agree, it make sense in such cases.
Thanks! 👍

skywinder added a commit that referenced this pull request Apr 6, 2015
Added "tag" to AbstractActionSheet
@skywinder skywinder merged commit 71c2665 into skywinder:master Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants