Update week1-07-sst-optimizations.md #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description has been changed to: 1. Display two separate has functions results as `hash1` and `hash2`. 2. Correctly state the bloom filter has 7 bits 3. Add a link to a post explaining bloom filters
skyzh
approved these changes
Feb 24, 2024
|
The linked bloom filter post looks so good! |
|
@skyzh Mind if I take a screenshot of your comment and PR and share it with the author? I think he'd be super happy to know more people appreciate his work and a bunch of students could potentially find value out of it! |
|
Yeah of course! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description has been changed to:
hash1andhash2.