Skip to content

Commit

Permalink
Add @types/lodash.clonedeep types (#3736)
Browse files Browse the repository at this point in the history
This lets us remove the `@ts-expect-error` comments from the `Keyboard`
module.
  • Loading branch information
alecgibson authored Apr 20, 2023
1 parent d2f689f commit 2165cf1
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 4 deletions.
4 changes: 0 additions & 4 deletions modules/keyboard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -762,14 +762,10 @@ function normalize(binding: Binding): BindingObject {
} else {
return null;
}
// @ts-expect-error
if (binding.shortKey) {
// @ts-expect-error
binding[SHORTKEY] = binding.shortKey;
// @ts-expect-error
delete binding.shortKey;
}
// @ts-expect-error
return binding;
}

Expand Down
19 changes: 19 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"@babel/preset-env": "^7.19.4",
"@playwright/test": "^1.27.1",
"@types/jasmine": "^4.3.0",
"@types/lodash.clonedeep": "^4.5.7",
"@typescript-eslint/eslint-plugin": "^5.38.0",
"@typescript-eslint/parser": "^5.38.0",
"babel-loader": "^8.2.5",
Expand Down

0 comments on commit 2165cf1

Please sign in to comment.