Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quill.getText() fails when using Bangla - QWERTY keyboard #1427

Closed
haugstrup opened this issue Apr 25, 2017 · 1 comment
Closed

quill.getText() fails when using Bangla - QWERTY keyboard #1427

haugstrup opened this issue Apr 25, 2017 · 1 comment

Comments

@haugstrup
Copy link
Contributor

haugstrup commented Apr 25, 2017

The space character is not handled correctly in the internal Quill storage when using Bangla - QWERTY keyboard layout.

Steps for Reproduction

  1. Install Bangla - QWERTY keyboard on a mac (System Prefs -> Input sources -> Search for "bengali")
  2. Switch to the Bangla - QWERTY keyboard
  3. Visit http://codepen.io/anon/pen/PmbbXW -- this is the Quill playground, but it outputs quill.getText() on every text-change
  4. Type "bvo" -- observe that বড়ো় is present in both the editor and below
  5. Hit the space key (optionally followed by another bvo sequence for a really messy result)

Expected behavior:

quill.getText() should match the visual strings in the editor

Actual behavior:

Looks like the space character is inserted before the o character (o being some sort of vowel modifier). The space should be inserted after the o modifier character and all will be well. I think.

Platforms:

Mac OS X Sierra. Latest versions of Chrome, Safari and Firefox.

Version:

1.2.4

@haugstrup
Copy link
Contributor Author

I'm happy to spend time troubleshooting and creating a PR to fix this issue, but I don't know where to start in Quill!

@jhchen jhchen closed this as completed in 0e7a10c May 18, 2017
jhchen added a commit that referenced this issue May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant