Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use text-decoration: underline and text-decoration: line-through #2585

Closed
krilllind opened this issue Apr 17, 2019 · 7 comments
Closed

Comments

@krilllind
Copy link

Steps for Reproduction

  1. Visit Quill js Playground
  2. Edit HTML to <span style="font-style: italic">My test</span>
    Expects output to be <em>My test</em> (true)
  3. Edit HTML to <span style="text-decoration: underline">My test</span>
    Expects output to be <b>My test</b> (false)

Expected behavior:
CSS style text-decoration: underline and text-decoration: line-through should be converted
into HTML tags <u> and <s>

Currently only font-weight: bold and font-style: italic works.

Actual behavior:
<span> element containing css values text-decoration: underline and text-decoration: line-through are not converted, but insted ignored and removed.

Platforms:
Tested in Google Chrome v73.0 Windows 10 x64

Version:
Tested in Quill js playground (v1.3.6)

@krilllind krilllind changed the title Unable to use text-decoration: underline and font-style: italic Unable to use text-decoration: underline and text-decoration: line-through Apr 18, 2019
@krilllind
Copy link
Author

Can someone please confirm this bug?

@edhowler
Copy link
Contributor

I confirm that it is still happening in 2.0.0-dev.3.

edhowler added a commit to edhowler/quill that referenced this issue Jul 11, 2019
fixing this: CSS style text-decoration: underline and text-decoration: line-through should be converted
into HTML tags <u> and <s>
@edhowler
Copy link
Contributor

edhowler commented Jul 11, 2019

I've made a pull request with the correction for this issue:
#2682

@Charlie50503
Copy link

It seem's not work for me.

my explame
https://codepen.io/CharlieKu50503/pen/gOWBmEo

is someone could share solution explame please.

@edhowler
Copy link
Contributor

edhowler commented Oct 8, 2021

It seem's not work for me.

my explame https://codepen.io/CharlieKu50503/pen/gOWBmEo

is someone could share solution explame please.

The original issue is for versions after 2.0.0, you are using version 1.3.6.

@pedrovgs
Copy link

I'm testing and facing the same bug in all the versions I've tested. Is there any workaround we can use here @edhowler @krilllind ? Thanks!

@quill-bot
Copy link

Quill 2.0 has been released (announcement post) with many changes and fixes. If this is still an issue please create a new issue after reviewing our updated Contributing guide 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants